Return expected version in the RTR server error PDU on mismatch. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjeker
reviewed
Jan 15, 2024
We’ll do that in a separate PR.
DRiKE
approved these changes
Jan 16, 2024
Co-authored-by: Luuk Hendriks <github@luukhendriks.eu>
partim
added a commit
that referenced
this pull request
Jan 17, 2024
Bug fixes * The RTR server now returns the expected protocol version in the version negotiation error message rather than the requested version. ([#280]) * The RTR server does not accept protocol version 2 for now to avoid sending illegal ASPA PDUs. This is a workaround until the final format of the PDU is specified. ([#281]) * Fixed protocol version negotiation in the RTR client. It will now error out if the server responds with a version greater than the requested one rather just accepting it. ([#282])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the version reported by the RTR server in the header of the RTR error PDU when a request has an invalid version. It returns the maximum supported version if a version hasn’t been negotiated yet. It returns the negotiated version if the client uses a different version after negotiation.
This fixes Routinator issue 919.